-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
koordlet: kill container after calling eviction api success #1759
koordlet: kill container after calling eviction api success #1759
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1759 +/- ##
==========================================
- Coverage 68.56% 68.56% -0.01%
==========================================
Files 430 430
Lines 39383 39408 +25
==========================================
+ Hits 27004 27020 +16
- Misses 10043 10048 +5
- Partials 2336 2340 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
3651941
to
709eb82
Compare
2213651
to
6996f57
Compare
memory evict is just like oom killer, which dose not restricted by pdb. |
How about add a koordlet feature-gate named |
d42f54e
to
c060754
Compare
also, please add a TODO comment for supporting fine-grained eviction arguments just like kubelet |
c060754
to
d51bcf8
Compare
Maybe you misunderstood me, I want to kill container on when calling eviction api returns ok, not eviction only by API. @zwzhang0107 |
Actually, after the eviction api returns ok, there is no need to kill container if you want to solve the grace termination or PDB problem. |
Got you, I will file a new patch later. |
d51bcf8
to
6e920a1
Compare
b49f9f4
to
29cc077
Compare
@zwzhang0107 PTAL |
This issue has been automatically marked as stale because it has not had recent activity.
|
/lgtm |
@j4ckstraw please solve the code conflicts, and we are good to go. |
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
Signed-off-by: j4ckstraw <j4ckstraw@foxmail.com>
29cc077
to
423e5b2
Compare
@zwzhang0107 rebased |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zwzhang0107 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ⅰ. Describe what this PR does
fix #1758
Ⅱ. Does this pull request fix one issue?
Ⅲ. Describe how to verify it
Ⅳ. Special notes for reviews
V. Checklist
make test